Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache get_decimals for every oracle #345

Merged
merged 2 commits into from
Sep 5, 2022
Merged

Cache get_decimals for every oracle #345

merged 2 commits into from
Sep 5, 2022

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Sep 2, 2022

@Uxio0
Cache get_decimals for every oracle
6f22a5f 
- Share token decimal cache for every oracle
- Related to #343
@Uxio0 Uxio0 requested a review from a team as a code owner September 2, 2022 14:49
@coveralls
Copy link

coveralls commented Sep 5, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2992103039

  • 12 of 16 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 89.842%
Changes Missing Coverage Covered Lines Changed/Added Lines %
gnosis/eth/oracles/oracles.py 9 13 69.23%
Totals Coverage Status
Change from base Build 2970925631: -0.1%
Covered Lines: 3414
Relevant Lines: 3800
💛 - Coveralls

@Uxio0 Uxio0 merged commit ed83837 into master Sep 5, 2022
@Uxio0 Uxio0 deleted the cache-oracles-get-decimals branch September 5, 2022 10:13
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmv08 mmv08 mmv08 approved these changes

@rmeissner rmeissner Awaiting requested review from rmeissner rmeissner was automatically assigned from safe-global/safe-services

@fmrsabino fmrsabino Awaiting requested review from fmrsabino fmrsabino was automatically assigned from safe-global/safe-services

@luarx luarx Awaiting requested review from luarx luarx was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Uxio0 @coveralls @mmv08