Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metis goerli testnet #379

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Add metis goerli testnet #379

merged 1 commit into from
Oct 21, 2022

Conversation

t0mcr8se
Copy link
Contributor

@t0mcr8se t0mcr8se commented Oct 19, 2022 •
edited
Loading

Pending

Waiting for safe-global/safe-singleton-factory#82 to be closed in order to deploy

@t0mcr8se t0mcr8se requested a review from a team as a code owner October 19, 2022 15:48
@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2022 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Uxio0
Copy link
Member

Uxio0 commented Oct 19, 2022

Let us know when it's available on https://chainlist.org/

@t0mcr8se
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Oct 19, 2022
@github-actions
@t0mcr8se has signed the CLA from Pull Request #379
1631862
@t0mcr8se
Copy link
Contributor Author

@Uxio0 it's available now on chainlist, ethereum-lists/chains#1736 was meged

@coveralls
Copy link

coveralls commented Oct 21, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3283046782

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 84.008%
Files with Coverage Reduction New Missed Lines %
gnosis/eth/ethereum_client.py 1 81.1%
Totals Coverage Status
Change from base Build 3263367183: 0.07%
Covered Lines: 3257
Relevant Lines: 3877
💛 - Coveralls

@Uxio0 Uxio0 merged commit c1d2c9d into safe-global:master Oct 21, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Uxio0 Uxio0 Uxio0 approved these changes

@fmrsabino fmrsabino Awaiting requested review from fmrsabino fmrsabino was automatically assigned from safe-global/safe-services

@moisses89 moisses89 Awaiting requested review from moisses89 moisses89 was automatically assigned from safe-global/safe-services

@luarx luarx Awaiting requested review from luarx luarx was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t0mcr8se @Uxio0 @coveralls