Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Safe EIP1271 message signing #383

Merged
merged 3 commits into from
Oct 31, 2022
Merged

Implement Safe EIP1271 message signing #383

merged 3 commits into from
Oct 31, 2022

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Oct 26, 2022

No description provided.

@coveralls
Copy link

coveralls commented Oct 28, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3345245584

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 36 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 83.87%
Files with Coverage Reduction New Missed Lines %
gnosis/safe/safe.py 36 87.61%
Totals Coverage Status
Change from base Build 3345086009: 0.02%
Covered Lines: 3281
Relevant Lines: 3912
💛 - Coveralls

@Uxio0 Uxio0 marked this pull request as ready for review October 28, 2022 12:00
@Uxio0 Uxio0 requested a review from a team as a code owner October 28, 2022 12:00
@Uxio0 Uxio0 merged commit b398877 into master Oct 31, 2022
@Uxio0 Uxio0 deleted the eip-1271-signing branch October 31, 2022 09:13
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moisses89 moisses89 moisses89 approved these changes

@rmeissner rmeissner Awaiting requested review from rmeissner rmeissner was automatically assigned from safe-global/safe-services

@fmrsabino fmrsabino Awaiting requested review from fmrsabino fmrsabino was automatically assigned from safe-global/safe-services

@luarx luarx Awaiting requested review from luarx luarx was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Uxio0 @coveralls @moisses89