-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create GitHub Issue template and GitHub action for add new Safe addresses #845
Conversation
.github/scripts/github_adding_addresses/create_pr_with_new_address.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good work! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good job Felipe. Could you add a small section on the README on how to add a new address that we can link when people don't follow the process?
@Uxio0 I will try to validate the process in this repo first and will do a follow up with the indications in the readme. Do you agree? |
closes: #826
To be considered:
Once the issue is created or edited there is a validator that will help us before executing the "/execute" command to check that all the fields are ok.
To check that the "/execute" command is executed by someone from the "core-api" team, you need to configure a new SECRET in the repository with permissions to read the teams. The secret will be called "TOKEN_GITHUB_READ_ORG_TEAMS" and is configured in the project settings under secrets and actions.