Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor contracts to use CREATE2 opcode #44

Closed
Georgi87 opened this issue Aug 6, 2018 · 2 comments
Closed

Refactor contracts to use CREATE2 opcode #44

Georgi87 opened this issue Aug 6, 2018 · 2 comments
Assignees
@rmeissner
Labels
enhancement onhold Blocked by external dependency

Comments

@Georgi87
Copy link
Contributor

Georgi87 commented Aug 6, 2018

The CREATE2 opcode ethereum/py-evm#269 has been merged and will be available in the next hardfork. Safe contracts should use CREATE2 to simplify the on-boarding. All new safe proxy contracts should be created and setup via a proxy factory using the CREATE2 opcode. This way we can ensure that the address of the future Safe only depends on the setup arguments. The required salt for CREATE2 can be a constant in the proxy factory.
@rmeissner
Copy link
Member

There are still quite some changes going on (Solidity implemented https://github.com/ethereum/EIPs/blob/master/EIPS/eip-86.md with opcode 0xfb, while the current EIP is https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1014.md with opcode 0xf5)

@rmeissner rmeissner self-assigned this Aug 13, 2018
@rmeissner rmeissner added personal_edition onhold Blocked by external dependency labels Aug 13, 2018
@rmeissner
Copy link
Member

Closed with #91

fdarian pushed a commit to fdarian/safe-contracts that referenced this issue Jan 14, 2024
@germartinez
Merge pull request safe-global#44 from gnosis/tx-options
b6f6b20 
Allow to override transaction options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmeissner rmeissner

Labels
enhancement onhold Blocked by external dependency
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Georgi87 @rmeissner and others