Implements #43: Use EIP-712 for hashing #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmeissner
added
enhancement
personal_edition
onhold
|
For the test to pass it is necessary that ganache implements |
Georgi87
approved these changes
Aug 15, 2018
rmeissner
force-pushed
the
feature/issue_43
branch
from
a9a8794
to
f5e563f
Compare
fdarian
pushed a commit
to fdarian/safe-contracts
that referenced
this pull request
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #43: Use EIP-712 for hashing
Uses EIP-712 for hashing. This will allow other key stores to sign safe transactions (e.g. MetaMask, Ledger, Trezor).
This introduces additional gas costs of ~20k on creation and ~700 per transaction.