Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination for all-transactions does not work well #1864

Closed
Uxio0 opened this issue Feb 8, 2024 · 1 comment · Fixed by #1865
Closed

Pagination for all-transactions does not work well #1864

Uxio0 opened this issue Feb 8, 2024 · 1 comment · Fixed by #1865
Assignees
@Uxio0
Labels
bug Something isn't working

Comments

@Uxio0
Copy link
Member

Uxio0 commented Feb 8, 2024

https://safe-transaction-gnosis-chain.safe.global/api/v1/safes/0xeda046C9f8fd29636Bb621892718B9754F244b97/all-transactions/?limit=17&offset=0&executed=true&trusted=true does not return the number of elements set by limit. It looks like it's related to caching of the endpoint
@Uxio0 Uxio0 added the bug Something isn't working label Feb 8, 2024
Uxio0 added a commit that referenced this issue Feb 8, 2024
@Uxio0
Fix pagination issues for all-transactions
9bafcb4 
- Closes #1864
@Uxio0 Uxio0 mentioned this issue Feb 8, 2024
Merged
Uxio0 added a commit that referenced this issue Feb 8, 2024
@Uxio0
Fix pagination issues for all-transactions
1d4b6b3 
- Closes #1864
Uxio0 added a commit that referenced this issue Feb 8, 2024
@Uxio0
Fix pagination issues for all-transactions
43ac607 
- Closes #1864
@JagoFigueroa
Copy link

Looks good to me, I can see that the expected number of transactions are being returned now when setting a limit 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Uxio0 Uxio0

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix pagination issues for all-transactions safe-global/safe-transaction-service
2 participants
@Uxio0 @JagoFigueroa