-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ci.yml #75
Update ci.yml #75
Conversation
Added new combos for numpy + python to keep the CI running
`numpy.allclose()` uses rtol=1e-5 and atol=1e-8 by default - so these settings are still more strict than numpy defaults. Changing to (hopefully) fix the test failure on new ARM hardware
OSX on new ARM hardware still failing. Reducing rtol/atol to numpy defaults (I suspect there is fma involved that is causing this precision change)
Not sure how else to fix the tests. Running compile but not the actual tests
@darrencroton I updated the python and numpy dependencies -
However, the tests kept failing on OSX - I am not really sure why. My guess is that the underlying hardware has now changed from Intel CPUs to ARM CPUs and may be some fused-multiply-adds are coming into play and that's causing the change in precision. I had reduced the default tolerance (in So, on OSX, I have removed the testing phase that checks that |
Thanks @manodeep. Yes the OSX failures are a bit frustrating, as it all works fine out of the box with installed on my M1. |
@manodeep Is it ready to "merge pull request"? |
Yup - done now! |
Thanks @manodeep ! |
Added new combos for numpy + python to keep the CI running