Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client-wide redirect policy not respected #251

Merged
merged 2 commits into from
Nov 11, 2020

Conversation

sagebind
Copy link
Owner

Fix a regression from #240 that caused redirect policies to be ignored if being set client-wide instead of per-request.

Fixes #250.

Fix a regression from #240 that caused redirect policies to be ignored if being set client-wide instead of per-request.

Fixes #250.
@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #251 (ff5f98c) into master (11bc004) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
+ Coverage   72.30%   72.46%   +0.15%     
==========================================
  Files          48       48              
  Lines        2423     2437      +14     
==========================================
+ Hits         1752     1766      +14     
  Misses        671      671              
Impacted Files Coverage Δ
src/client.rs 70.99% <100.00%> (+0.33%) ⬆️
tests/redirects.rs 98.92% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11bc004...ff5f98c. Read the comment docs.

@sagebind sagebind merged commit 6d8186b into master Nov 11, 2020
@sagebind sagebind deleted the 250-client-redirect-policy branch November 11, 2020 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change from 0.9.10 to 0.9.11 due to #240 (presumably)
1 participant