Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for forcing a specific ip protocal version #253

Merged
merged 2 commits into from
Nov 14, 2020

Conversation

ArenM
Copy link
Contributor

@ArenM ArenM commented Nov 12, 2020

Support specifying the ip protocol version to use, like to curl -4 and curl -6.
fixes #252

@ArenM ArenM requested a review from sagebind as a code owner November 12, 2020 00:02
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #253 (ab35df5) into master (a9d71aa) will decrease coverage by 0.45%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
- Coverage   72.53%   72.07%   -0.46%     
==========================================
  Files          49       49              
  Lines        2443     2435       -8     
==========================================
- Hits         1772     1755      -17     
- Misses        671      680       +9     
Impacted Files Coverage Δ
src/client.rs 70.49% <ø> (-0.28%) ⬇️
src/config/mod.rs 56.66% <0.00%> (-4.05%) ⬇️
src/request.rs 27.45% <0.00%> (-0.55%) ⬇️
src/task.rs 90.90% <0.00%> (-1.69%) ⬇️
src/body.rs 75.38% <0.00%> (-0.81%) ⬇️
src/handler.rs 71.31% <0.00%> (-0.06%) ⬇️
src/text.rs 68.08% <0.00%> (ø)
src/agent.rs 68.58% <0.00%> (ø)
src/response.rs 82.35% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9d71aa...ab35df5. Read the comment docs.

Copy link
Owner

@sagebind sagebind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! Just a few suggestions on docs and naming, but otherwise looks good!

src/config/mod.rs Outdated Show resolved Hide resolved
src/config/mod.rs Outdated Show resolved Hide resolved
@ArenM
Copy link
Contributor Author

ArenM commented Nov 13, 2020

Thanks for the comments, I'm not good at writing docs or naming things.

Copy link
Owner

@sagebind sagebind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@sagebind sagebind merged commit 0515b13 into sagebind:master Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make request on only ipv4 or ipv6
2 participants