-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add post_async example usage #273
Conversation
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
=======================================
Coverage 72.96% 72.96%
=======================================
Files 51 51
Lines 2715 2715
=======================================
Hits 1981 1981
Misses 734 734
Continue to review full report at Codecov.
|
I'd rather avoid using rustfmt for now as I haven't up until now; sometimes rustfmt makes some silly choices by default that I think makes it harder to read. I could make a In addition, I think this complicates this PR when it could be a simpler diff. Formatting changes always have bigger diffs that can make it hard to spot changes when mixed with non-formatting changes. |
How to unify the code style of multi-person development and avoid merge conflicts? And |
I get the sentiment and to some extent I agree. I think using something like rustfmt is generally a good idea, but I disagree with the some of the default styling rules (and this isn't really the right forum to debate the specifics). And the way it works right now, almost all options are ignored unless you use the nightly Rust toolchain and nightly rustfmt. In practice this has rarely been an issue, so I haven't bothered to address it specifically.
Indeed, but 99% of those options result in something like
Because most of the useful options are nightly-only, and potential contributors are unlikely to switch to the nightly channel just to run |
* remove async_std * remove tokio with dev-dependencies. Replace with futures-lite
Seems good to me now, but could you please revert the unrelated formatting changes? I like to keep the diffs clean so it is easier to spot what a merged commit does in the future. Thanks. |
It's has been roolback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
post_async
examplecargo fmt