Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add post_async example usage #273

Merged
merged 7 commits into from
Dec 15, 2020
Merged

add post_async example usage #273

merged 7 commits into from
Dec 15, 2020

Conversation

baoyachi
Copy link
Contributor

  • add post_async example
  • format code use command with cargo fmt

@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #273 (9a86688) into master (876cc03) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #273   +/-   ##
=======================================
  Coverage   72.96%   72.96%           
=======================================
  Files          51       51           
  Lines        2715     2715           
=======================================
  Hits         1981     1981           
  Misses        734      734           
Impacted Files Coverage Δ
src/lib.rs 77.77% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 876cc03...9a86688. Read the comment docs.

Cargo.toml Outdated Show resolved Hide resolved
@sagebind
Copy link
Owner

sagebind commented Dec 11, 2020

format code use command with cargo fmt

I'd rather avoid using rustfmt for now as I haven't up until now; sometimes rustfmt makes some silly choices by default that I think makes it harder to read. I could make a rustfmt.toml file to correct those, I just haven't yet.

In addition, I think this complicates this PR when it could be a simpler diff. Formatting changes always have bigger diffs that can make it hard to spot changes when mixed with non-formatting changes.

@baoyachi
Copy link
Contributor Author

baoyachi commented Dec 11, 2020

format code use command with cargo fmt

I'd rather avoid using rustfmt for now as I haven't up until now; sometimes rustfmt makes some silly choices by default that I think makes it harder to read. I could make a rustfmt.toml file to correct those, I just haven't yet.

In addition, I think this complicates this PR when it could be a simpler diff. Formatting changes always have bigger diffs that can make it hard to spot changes when mixed with non-formatting changes.

How to unify the code style of multi-person development and avoid merge conflicts?

And cargo fmt support custom config:https://github.com/rust-lang/rustfmt/blob/master/Configurations.md

@sagebind
Copy link
Owner

sagebind commented Dec 11, 2020

I get the sentiment and to some extent I agree. I think using something like rustfmt is generally a good idea, but I disagree with the some of the default styling rules (and this isn't really the right forum to debate the specifics). And the way it works right now, almost all options are ignored unless you use the nightly Rust toolchain and nightly rustfmt.

In practice this has rarely been an issue, so I haven't bothered to address it specifically.

And cargo fmt support custom config:https://github.com/rust-lang/rustfmt/blob/master/Configurations.md

Indeed, but 99% of those options result in something like

Warning: can't set `imports_layout = "HorizontalVertical"`, unstable features are only available in nightly channel.

Because most of the useful options are nightly-only, and potential contributors are unlikely to switch to the nightly channel just to run cargo fmt.

* remove async_std
* remove tokio
with dev-dependencies. Replace with futures-lite
@sagebind
Copy link
Owner

Seems good to me now, but could you please revert the unrelated formatting changes? I like to keep the diffs clean so it is easier to spot what a merged commit does in the future. Thanks.

@baoyachi
Copy link
Contributor Author

It's has been roolback cargo fmt code

Copy link
Owner

@sagebind sagebind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sagebind sagebind merged commit 25513c6 into sagebind:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants