Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply rustfmt to entire repo #277

Merged
merged 8 commits into from
Dec 17, 2020
Merged

Apply rustfmt to entire repo #277

merged 8 commits into from
Dec 17, 2020

Conversation

sagebind
Copy link
Owner

@sagebind sagebind commented Dec 16, 2020

Apply newly added rustfmt configuration from #276 to the entire repo. This will be the start of a clean slate going forward for consistent formatting.

In addition, this PR is to test semi-automated formatting with the @teto-bot rustfmt command, which can be invoked from any PR by the PR author or by an Isahc maintainer. Indeed, the formatting proposed by this PR was all automated.

@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #277 (ff1ff7a) into master (9eb6ad8) will decrease coverage by 0.20%.
The diff coverage is 76.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
- Coverage   72.96%   72.76%   -0.21%     
==========================================
  Files          51       51              
  Lines        2715     2735      +20     
==========================================
+ Hits         1981     1990       +9     
- Misses        734      745      +11     
Impacted Files Coverage Δ
benchmarks/src/lib.rs 0.00% <ø> (ø)
src/auth.rs 67.18% <ø> (ø)
src/config/dial.rs 68.62% <ø> (ø)
src/config/dns.rs 36.36% <ø> (ø)
src/config/mod.rs 56.66% <ø> (ø)
src/cookies/psl/mod.rs 83.33% <ø> (ø)
src/default_headers.rs 100.00% <ø> (ø)
src/error.rs 46.15% <0.00%> (-1.68%) ⬇️
src/interceptor/context.rs 75.00% <ø> (ø)
src/interceptor/mod.rs 0.00% <0.00%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eb6ad8...ff1ff7a. Read the comment docs.

@sagebind sagebind changed the title Test PR Apply rustfmt Dec 16, 2020
@sagebind
Copy link
Owner Author

@teto-bot rustfmt

@sagebind sagebind marked this pull request as ready for review December 17, 2020 03:42
@sagebind sagebind changed the title Apply rustfmt Apply rustfmt to entire repo Dec 17, 2020
@sagebind sagebind merged commit dd3745b into master Dec 17, 2020
@sagebind sagebind deleted the pr-test branch December 17, 2020 04:14
@sagebind sagebind mentioned this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant