Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update future types to be Send #285

Merged
merged 4 commits into from
Dec 31, 2020
Merged

Update future types to be Send #285

merged 4 commits into from
Dec 31, 2020

Conversation

sagebind
Copy link
Owner

@sagebind sagebind commented Dec 31, 2020

Update future types used by AsyncReadResponseExt to be Send whenever T is Send as appropriate. Consolidate the newtype futures with a macro that handles conditional Send properly to reduce boilerplate and chance of mistakes.

Fixes #283.

Update future types used by `AsyncReadResponseExt` to be `Send` whenever `T` is `Send` as appropriate. Consolidate the newtype futures with a macro that handles conditional Send properly to reduce boilerplate and chance of mistakes.

Fixes #283.
@sagebind
Copy link
Owner Author

@teto-bot rustfmt

@codecov
Copy link

codecov bot commented Dec 31, 2020

Codecov Report

Merging #285 (4fe9f7e) into master (48e4913) will increase coverage by 0.13%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
+ Coverage   72.65%   72.79%   +0.13%     
==========================================
  Files          51       51              
  Lines        2732     2727       -5     
==========================================
  Hits         1985     1985              
+ Misses        747      742       -5     
Impacted Files Coverage Δ
src/response.rs 70.00% <0.00%> (+9.13%) ⬆️
src/text.rs 74.41% <0.00%> (+3.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48e4913...4fe9f7e. Read the comment docs.

@sagebind sagebind merged commit dc3a3cb into master Dec 31, 2020
@sagebind sagebind deleted the future-send branch December 31, 2020 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 1.0 cannot use asynchronous copy_to_file?
2 participants