-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor request configuration internal representation #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #292 +/- ##
==========================================
+ Coverage 73.02% 75.51% +2.48%
==========================================
Files 53 55 +2
Lines 2773 2822 +49
==========================================
+ Hits 2025 2131 +106
+ Misses 748 691 -57
Continue to review full report at Codecov.
|
@teto-bot rustfmt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor how request configuration is represented internally from a purely extension-based model into a centralized struct. This reduces the generalized code somewhat, but makes it easier to understand for people less familiar with the codebase.
More importantly, this delivers a 5-10% performance improvement in synthetic benchmarks, since it greatly reduces the number of wasteful hashmap lookups we do when trying to apply request configuration to an easy handle.