Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for in-memory certificates #320

Merged
merged 3 commits into from
Apr 23, 2021
Merged

Add support for in-memory certificates #320

merged 3 commits into from
Apr 23, 2021

Conversation

sagebind
Copy link
Owner

Pull in new bindings for the new blob APIs added to curl in 2020. Bindings were recently added in alexcrichton/curl-rust#384. This of course only works when using a fairly new curl version.

Addresses #89.

Pull in new bindings for the new blob APIs added to curl in 2020. Bindings were recently added in alexcrichton/curl-rust#384. This of course only works when using a fairly new curl version.

Addresses #89.
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #320 (6a399fc) into master (6f1c7b6) will decrease coverage by 0.26%.
The diff coverage is 8.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #320      +/-   ##
==========================================
- Coverage   74.94%   74.67%   -0.27%     
==========================================
  Files          57       57              
  Lines        2993     3009      +16     
==========================================
+ Hits         2243     2247       +4     
- Misses        750      762      +12     
Impacted Files Coverage Δ
src/config/ssl.rs 35.00% <8.33%> (-8.75%) ⬇️
src/error.rs 45.33% <0.00%> (+0.66%) ⬆️
src/handler.rs 71.10% <0.00%> (+1.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f1c7b6...6a399fc. Read the comment docs.

@sagebind
Copy link
Owner Author

Once the new bindings are published in a new curl release we can merge this.

@sagebind sagebind marked this pull request as ready for review April 17, 2021 14:54
@sagebind sagebind merged commit 983c2e6 into master Apr 23, 2021
@sagebind sagebind deleted the in-memory-certs branch April 23, 2021 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant