-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove lifetime from Context, ResponseFuture, InterceptorFuture #405
Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Codecov Report
@@ Coverage Diff @@
## master #405 +/- ##
==========================================
+ Coverage 51.94% 52.09% +0.14%
==========================================
Files 52 52
Lines 5796 5787 -9
==========================================
+ Hits 3011 3015 +4
+ Misses 2785 2772 -13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Hi, @sagebind, can you take a look into this PR? Thanks! |
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@sagebind I did some refactor on this PR, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for my prolonged absence, this looks fantastic! Thanks so much for your work on this.
This PR will fix #403
The benchmark seems can't reflect the actual improvement. (I guess the test case(64K) is not suitable to measure the different between an
Arc::new
)Before:
After