Rewrite error functions and documentation

[rwst]

This ticket should accomplish:

• implement inverse error function erfinv (Doctest fix for: Sage can't make sense of a Maxima result #11349)
• implement imaginary error function erfi.
• People need to manipulate statistical distribution functions as in https://ask.sagemath.org/question/35407/use-cumulative-distribution-functions/. To provide the means a symbolical version of erfc is necessary. The current error_fcn() is only numerical.
• put it all in a separate file functions/error.py with central documentation

http://dlmf.nist.gov/7

Component: symbolics

Author: Ralf Stephan

Branch/Commit: 1eac4d8

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/21819

[rwst]

Dependencies: #11349

[rwst]

Branch: u/rws/rewrite_error_functions_and_documentation

[rwst]

Changed dependencies from #11349 to none

[rwst]

New commits:

fbb77c0

21819: erf() reorg

[rwst]

Author: Ralf Stephan

[rwst]

Commit: fbb77c0

[paulmasson]

comment:5

The name error_fcn is nonstandard. I think it should be deprecated with an appropriate warning.

A couple minor things in the documentation in error.py:

1. One LaTeX instance of \text should be \operatorname

2. Five instances of code markdown in the AUTHORS section need double back ticks instead of single.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

801c42a	Merge branch 'develop' into t/21819/rewrite_error_functions_and_documentation
3c5739e	21819: address reviewer's comments; maxima erfc bindings

[sagetrac-git]

Changed commit from fbb77c0 to 3c5739e

[fchapoton]

comment:7

failing doctests

[sagetrac-git]

Changed commit from 3c5739e to be39e50

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

2fb1d2d	Merge branch 'develop' into t/21819/rewrite_error_functions_and_documentation
be39e50	21819: fixes

[fchapoton]

comment:10

does not apply

[sagetrac-git]

Changed commit from be39e50 to 7fade55

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

7fade55

Merge branch 'develop' into t/21819/rewrite_error_functions_and_documentation

[rwst]

New commits:

7fade55

Merge branch 'develop' into t/21819/rewrite_error_functions_and_documentation

[rwst]

Changed branch from u/rws/rewrite_error_functions_and_documentation to u/rws/21819-1

[rwst]

Changed commit from 7fade55 to b56829c

[rwst]

comment:14

Squashed and lazy import added.

---

New commits:

b56829c

21819: Rewrite error functions and documentation

[tscrim]

comment:15

In error.py, there is no reason to deprecate error_fcn there. I would do that in the original location. You should also have lazy_imports deprecations that redirect to the new location.

[rwst]

comment:16

Do you have an idea why the patchbot's startup_modules plugin still triggers?

[sagetrac-git]

Changed commit from b56829c to e96e7e1

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

e96e7e1

21819: move error_fcn back to functions.other

[rwst]

comment:18

Replying to @tscrim:

... You should also have lazy_imports deprecations that redirect to the new location.

I tried but I don't think lazy_import's deprecation arg does what I think you're trying to do.

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

Changed branch from u/rws/21819-1 to public/symbolics/rewrite_error_functions-21819

[tscrim]

comment:20

I was going to try, but then I felt lazy and the current version works just fine. I made a few documentation tweaks. If my changes are good with you, then you can set a positive review.

---

New commits:

df32cc6	Merge branch 'u/rws/21819-1' of git://trac.sagemath.org/sage into public/symbolics/rewrite_error_functions-21819
1eac4d8	Some small tweaks to the doc.

[tscrim]

Changed commit from e96e7e1 to 1eac4d8

[rwst]

comment:21

Looks good and tests in functions are fine. Thanks for the help with this.

[tscrim]

comment:22

Sorry I let this drop off my radar.

[vbraun]

Changed branch from public/symbolics/rewrite_error_functions-21819 to 1eac4d8