-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the sage notebook optional #25837
Comments
comment:1
Some issues I'm aware of related to features that are only in sagenb:
I think at a minimum these issues should be fixed before taking further steps at abandoning the old sagenb. |
comment:2
I would also say that something "official" when one uses sagenb even when directly that says it is deprecated is necessary. |
This comment has been minimized.
This comment has been minimized.
comment:4
I modified the ticket description to incorporate (read: shamelessly copy) your additions. It would be nice if we could get the deprecation warning into 8.3 so that users will have at least one release to prepare. Thats a very optimistic estimate of course, but getting it in 8.3 would be nice either way. |
This comment has been minimized.
This comment has been minimized.
comment:5
I have opened #25852 for that. I have only ever actually started the notebook once. Do you have an idea where best to add such a message? Just print it on the command line? |
comment:6
Probably on the notebook itself as well, which would require changes in sagenb. |
comment:7
cc a few people who package Sage in various ways |
Changed keywords from notebook to notebook, sagenb |
comment:8
Another issue that was brought up here: https://ask.sagemath.org/question/43051/file-download-as-latex/ Converting a Jupyter notebook to PDF kind of sucks at the moment for notebooks that contain a lot of math in latex. There are two main cases in the notebook where latex can appear, and both have issues in sage:
I'm not sure what to do about the first case; it seems like an issue for nbconvert but I haven't explored it too deeply. For the latter case (which probably also affects the first case) I wonder if we shouldn't just make pandoc another sage dependency. |
This comment has been minimized.
This comment has been minimized.
comment:9
I've updated the ticket. The flask issue was resolved (thanks @fchapoton!), I added the pdf complaint and improved formatting. |
This comment has been minimized.
This comment has been minimized.
comment:11
I've added a section intended for end users. Please improve on that if you have more knowledge about sagenb or the Jupyter Notebook, which you probably do. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:15
Where is the list? I can't find it. I touched on this on page 26 of a talk I gave yesterday (https://share.cocalc.com/share/6cd832d3-c523-41e3-9e54-c8f2d2e8fa2a/travel/2018/2018-07-icms/talks/cocalc/slides/slides.html#1) One example is that if you start running:
then close and open your browser (to simulate a network failure, say), you |
comment:16
Replying to @williamstein:
It's in the description of the ticket, but perhaps that still needs more reformatting, because there are a number of thing "below" that sentence that include, but are not limited to, missing features. Most of it falls under the heading "Functionality sagenb currently does better than Jupyter" though that list is far from complete. There's also a link to a wiki page listing other issues. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:19
"#24784: search_doc does not work in the Jupyter notebook" is now ready for review. |
comment:20
Could someone (having the required rights) please now merge the 4 top pull requests in sagenb github, including the one related to the present ticket ? |
comment:21
Replying to @fchapoton:
done, I guess. See #26499 for the new release of sagenb. |
Branch: u/chapoton/25837 |
New commits:
|
comment:42
When we talk about regressions, I think the context is: we are imagining people converting their notebooks from SageNB to Jupyter and not using SageNB any more (as opposed to: using SageNB for some tasks, Jupyter for others). In that context, it is also worthwhile to ask what features Jupyter has that SageNB doesn't. I don't think we are just losing things by moving from SageNB to Jupyter; aside from Python 3 compatibility, I think we gain some things by moving to Jupyter. So it is a trade-off. At what point does the balance tip to the Jupyter side? Maybe the Python 3 support is enough on its own, in fact. |
comment:43
Obviously that is the consensus decision. I'm just quoting this ticket right now when I mention these things, and would hate to have them disappear for all time. But as you said elsewhere, someone has to work on them. |
comment:44
A functionality that Jupyter is currently missing over sagenb is the rich text editor. This may possibly be resolved by: https://github.com/jupytercalpoly/jupyterlab-richtext-mode |
comment:45
the most pressing issue is inability to normally use jsmol in Jupyter notebooks, needed to export 3d drawings for animations. We are having a lot of complaints about it. jupyter/notebook#1872 discussing this has been opened in 2016 (pity that it was not resolved during ODK). |
comment:46
Indeed; too bad this was not brought up. That being said, we still are in good contact with the Jupyter team :-) So if we provide them with a specific and easy to reproduce example (e.g. through a binder link) on the above issue, there are chances that we can make progress. It would be worth testing how things are in jupyterlab too. |
comment:47
By the way, I note that only jsmol can make stereographic plots for 3d viewing, though I don't know how often this capability is used. (People like it when advertising Sage!) |
comment:48
Replying to @kcrisman:
can't plotly do it? see e.g. https://plot.ly/~empet/13037.embed |
comment:49
By "only jsmol", I meant the only thing included standard in Sage. What is plotly? (Am I so behind that I missed a major new Sage internal plot mechanism? Yikes.) |
comment:50
I read your comments as "the only Python library that can do this sort if plotting" plotly is Python library, no idea if it can work in Sage. |
comment:51
Ticket retargeted after milestone closed |
Changed reviewer from Dima Pasechnik to Dima Pasechnik, John Palmieri |
If you're coming from the deprecation notice in the notebook
The legacy SageNB notebook has been effectively deprecated for quite some time.
We are now making that official.
But that does not mean that Sage will not have notebook functionality.
In fact, most of the functionality of the sage notebook can already be replaced by using the Juypter Notebook instead.
For an introduction on how to use the new notebook and convert existing notebooks, see the documentation.
There are some features that are not yet ported to the new notebook however.
We will not completely stop supporting the legacy notebook until those issues are resolved.
Those features are listed below. If there is some feature you're missing that is not listed or you want to give general feedback, feel free to leave a comment on this ticket. If you do not have an account yet, you can log in with a GitHub account.
Implementation details
Reasons to make sagenb optional
most of its functionality has been replaced for a while by Jupyter
it is not actively maintained -- merely on life support
it has various open issues (looking at the "Critical" label in the github repo)
and for me personally: I don't want to package it. I feel like it causes a disproportionate amount of issues considering its relatively low value in today's Sage.
Reasons to keep sagenb around
there are still some features depending on it
there might still be people using it. An example would be @kiwifb's university: #25382 comment:16
In making it optional, we still make it possible to use it for now. And when it inevitably breaks further, the people relying on it can weigh the effort of keeping it alive themselves against the effort of switching to the new notebook.
Tickets and issues tracking progress/going in that direction
Necessary to keep all tested behaviour intact without sagenb ("pass the doctests")
Add package phitigra: Graph editor that works with Jupyter #30540: port/remove the graph editor
port/remove the graph database navigator
port/remove the interactive debugger
py3: do not include the notebook documentation in sage #25382: do not include sagenb docs in sage
Misc changes
Add a deprecation warning to the legacy sage notebook #25852: add a deprecation warning to the sage notebook
Make the sage notebook optional #25837: actually make sagenb optional
Functionality sagenb currently does better than Jupyter
Improve introspection capabilities of Sage Jupyter Kernel #25015: object introspection (
<obj>?
) in the Jupyter notebook does not display HTML-formatted docs (esp. with latex formatting), while sagenb doessearch_doc broken with jupyter notebook #24784:
search_doc
does not work in the Jupyter notebookinconsistencies between the terminal version and the notebook #9048:
automatic_names
only works in sagenbJupyter's converting to PDF "kind of sucks" (see Broken typeset in pdf export of Jupyter notebook #23330)
Inline
view
in the Jupyter notebook #26101: With Jupyter,view(...)
currently displays the pdf in an external pdf viewer, launched from the server. An inline view as in sagenb is nicer and would work remotely as well.Jupyter does not scroll large output (e.g. matrices) well; see this post on Stackoverflow
probably supports matrix input, which does work in Sage cell server but not in Jupyter as of this Sage support discussion
Otherwise relevant
CC: @embray @vbraun @jdemeyer @kcrisman @kiwifb @antonio-rojas @timokau @infinity0 @novoselt @pcpa @nthiery @slel @saraedum @haraldschilly @strogdon @tobihan @sagetrac-tmonteil @williamstein
Component: packages: standard
Keywords: notebook, sagenb
Branch/Commit: u/chapoton/25837 @
ec7931a
Reviewer: Dima Pasechnik, John Palmieri
Issue created by migration from https://trac.sagemath.org/ticket/25837
The text was updated successfully, but these errors were encountered: