Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ManifoldSubset: Replace use of _top_subsets by a generator #31766

Open
mkoeppe opened this issue May 2, 2021 · 3 comments
Open

ManifoldSubset: Replace use of _top_subsets by a generator #31766

mkoeppe opened this issue May 2, 2021 · 3 comments
Labels
c: manifolds p: major / 3 t: enhancement

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented May 2, 2021

... of the maximal elements of the subset poset.

Depends on #31736
Depends on #31764

CC: @mjungmath @egourgoulhon

Component: manifolds

Issue created by migration from https://trac.sagemath.org/ticket/31766
@mkoeppe mkoeppe added this to the sage-9.4 milestone May 2, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 2, 2021

Changed dependencies from #31736 to #31736, #31764

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 3, 2021

comment:2

Actually _top_subsets is only used in one place, in TensorField.along.

Perhaps it is possible to get rid of it altogether?

@mjungmath
Copy link

comment:3

Oh, something similar happens for the volume form and the display method of scalar fields. Moreover, see _get_min_covering in manifold.py.

@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 14, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Mar 5, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 7, 2023
@mkoeppe mkoeppe removed this from the sage-10.0 milestone Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: manifolds p: major / 3 t: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkoeppe @mjungmath