-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace OpenInterval, RealLine instances by instances of a subclass of DifferentiableManifold+RealSet #31878
Comments
This comment has been minimized.
This comment has been minimized.
mkoeppe
changed the title
OpenInterval(-oo, oo) vs RealLine()
Replace OpenInterval, RealLine instances by an instance of a subclass of DifferentiableManifold+RealSet
May 30, 2021
mkoeppe
changed the title
Replace OpenInterval, RealLine instances by an instance of a subclass of DifferentiableManifold+RealSet
Replace OpenInterval, RealLine instances by instances of a subclass of DifferentiableManifold+RealSet
May 30, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(from discussion in #30832 comment:14)
We represent open intervals and the real line, when they are to be considered as manifold objects, as an instance of a subclass of
DifferentiableManifold
andRealSet
.Likewise, arbitrary finite unions of intervals become instances of a subclass of
ManifoldSubset
andRealSet
.Compared to
ManifoldSubset
, the methodsunion
andintersection
are replaced by a more specific implementation.OpenInterval
andRealLine
will no longer be classes, only constructors.More general implementation using #31688 (pullbacks of subsets under continuous maps). In this case we would not need to subclass
RealSet
, but rather we would use a pullback.This will also solve #30830 comment:18:
OpenInterval
should silently return aRealLine
instance iflower == minus_infinity
andupper == infinity
.Some API changes to consider:
RealSets.point
clashes withManifold.point
, could replace byRealSets.singleton
.OpenInterval.upper_bound
,OpenInterval.lower_bound
RealSet
: Replaceis_included_in
,is_disjoint_from
byis_subset
,is_disjoint
RealSet.are_pairwise_disjoint
,contains
ManifoldSubset.complement
has optional argsuperset
RealSet.open
vsOpenInterval.open_interval
RealSet.cardinality
,n_components
ManifoldSubset.has_defined_points
Depends on #31881
CC: @egourgoulhon @tscrim @mjungmath
Component: manifolds
Issue created by migration from https://trac.sagemath.org/ticket/31878
The text was updated successfully, but these errors were encountered: