Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version ranges in install-requires.txt for several recently updated packages #32071

Closed
mkoeppe opened this issue Jun 27, 2021 · 8 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 27, 2021

While working on #32069, I got these errors triggered by pip install:

[jupyterlab] sagemath-standard 9.4b3 requires scipy<1.6,>=1.5, but you have scipy 1.6.3 which is incompatible.
[jupyterlab] sagemath-standard 9.4b3 requires sphinx<3.3,>=3, but you have sphinx 4.0.1 which is incompatible.
[jupyterlab] sagemath-standard 9.4b3 requires sympy<1.8,>=1.6, but you have sympy 1.8 which is incompatible.

The upgrade tickets #31647, #31696, #31008 forgot to update the version ranges. We fix it in this ticket.

CC: @kiwifb @antonio-rojas @kliem @isuruf

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: 0075b33

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/32071

@mkoeppe mkoeppe added this to the sage-9.4 milestone Jun 27, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 27, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 27, 2021

comment:2

The new ranges are just guesswork


New commits:

0075b33build/pkgs/{scipy,sphinx,sympy}/install-requires.txt: Update version ranges to include the version in package-version.txt

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 27, 2021

Commit: 0075b33

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 27, 2021

Author: Matthias Koeppe

@kiwifb
Copy link
Member

kiwifb commented Jun 27, 2021

Reviewer: François Bissey

@kiwifb
Copy link
Member

kiwifb commented Jun 27, 2021

comment:4

Version range are always a tricky issue. You cannot predict when things will break. So guessing is actually fine. At least you put some upper bounds.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 27, 2021

comment:5

Thanks!

@vbraun
Copy link
Member

vbraun commented Jun 29, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants