Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cysignals: Replace compile-time dependency on pari by run-time dispatch #32431

Open
mkoeppe opened this issue Aug 28, 2021 · 13 comments
Open

cysignals: Replace compile-time dependency on pari by run-time dispatch #32431

mkoeppe opened this issue Aug 28, 2021 · 13 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 28, 2021

Upstream issue:

sagemath/cysignals#125

CC: @kliem @tscrim @videlec @dimpase

Component: packages: standard

Work Issues: cypari2 and cysignals need new releases

Author: Jonathan Kliem

Branch/Commit: public/32431 @ 0353619

Issue created by migration from https://trac.sagemath.org/ticket/32431

@mkoeppe mkoeppe added this to the sage-9.5 milestone Aug 28, 2021
@kliem
Copy link
Contributor

kliem commented Aug 31, 2021

comment:2

See sagemath/cysignals#149.

Seems to work for me (when adding

# distutils: libraries = pari

to cypari2/types.pxd.

@kliem
Copy link
Contributor

kliem commented Aug 31, 2021

comment:3

But currently cysignals own tests are failing. Will see tomorrow what is going on.

@kliem
Copy link
Contributor

kliem commented Sep 1, 2021

Author: Jonathan Kliem

@kliem
Copy link
Contributor

kliem commented Sep 1, 2021

comment:4

It looks like this can be solved with

sagemath/cysignals#149

and

sagemath/cypari2#108.


New commits:

cee84d1Replace compile-time dependency on pari by run-time dispatch

@kliem
Copy link
Contributor

kliem commented Sep 1, 2021

Work Issues: cypari2 and cysignals need new releases

@kliem
Copy link
Contributor

kliem commented Sep 1, 2021

Branch: public/32431

@kliem
Copy link
Contributor

kliem commented Sep 1, 2021

Commit: cee84d1

@kliem
Copy link
Contributor

kliem commented Sep 2, 2021

Attachment: cypari2-2.1.3b1.tar.gz

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 2, 2021

comment:5

Attachment: cysignals-1.11.0a0.dev0.tar.gz

Branch pushed to git repo; I updated commit sha1. New commits:

8c91984updated function signatures
0c81e31add doctests that confirms that cysignals interfaces the PARI signals

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 2, 2021

Changed commit from cee84d1 to 0c81e31

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 2, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

0353619fixed merge conflict

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 2, 2021

Changed commit from 0c81e31 to 0353619

@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 18, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Mar 5, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 11, 2022

comment:12

What's the status here?

@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 7, 2023
@mkoeppe mkoeppe removed this from the sage-10.0 milestone Mar 16, 2023
vbraun pushed a commit to vbraun/sage that referenced this issue Aug 27, 2024
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

- https://pypi.org/project/cypari2/2.2.0/
- https://github.com/sagemath/cypari2/blob/master/NEWS
- Another step toward sagemath#32431

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38183
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this issue Aug 28, 2024
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

- https://pypi.org/project/cypari2/2.2.0/
- https://github.com/sagemath/cypari2/blob/master/NEWS
- Another step toward sagemath#32431

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38183
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants