Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sympy to 1.11.1 #34118

Closed
mkoeppe opened this issue Jul 5, 2022 · 31 comments
Closed

Update sympy to 1.11.1 #34118

mkoeppe opened this issue Jul 5, 2022 · 31 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 5, 2022

SymPy 1.11 was released on 2022-08-23.
https://github.com/sympy/sympy/wiki/release-notes-for-1.11

This ticket also serves as the target of SymPy's ci-sage workflow after sympy/sympy#23728

CC: @kiwifb @oscarbenjamin @antonio-rojas @DaveWitteMorris

Component: packages: standard

Author: Oscar Benjamin, Matthias Koeppe

Branch/Commit: 5281574

Reviewer: Matthias Koeppe, Antonio Rojas, Eric Gourgoulhon

Issue created by migration from https://trac.sagemath.org/ticket/34118

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 5, 2022

Branch: u/mkoeppe/sympy_1_11

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 5, 2022

Commit: 08dc8fd

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 5, 2022

New commits:

58d62f4build/bin/write-dockerfile.sh: ADD src/VERSION.txt
8ed04b9Merge #34017
d835afcbuild/pkgs/python3/distros/cygwin.txt: Add packages needed for ensurepip
08dc8fdMerge #34088

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 5, 2022

Dependencies: #34017, #34088

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 6, 2022

comment:5

Current failures: see sympy/sympy#23728 (comment)

@mkoeppe mkoeppe changed the title sympy 1.11 Update sympy to 1.11 Jul 8, 2022
@oscarbenjamin
Copy link

Changed branch from u/mkoeppe/sympy_1_11 to u/gh-oscarbenjamin/sympy_1_11

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 11, 2022

Changed dependencies from #34017, #34088 to none

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 11, 2022

Author: Oscar Benjamin

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 11, 2022

New commits:

04d0344Update doctests for SymPy 1.11

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 11, 2022

Changed commit from 08dc8fd to 04d0344

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 25, 2022

Changed branch from u/gh-oscarbenjamin/sympy_1_11 to u/mkoeppe/sympy_1_11

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 25, 2022

New commits:

a6ab4fabuild/pkgs/sympy: Update to 1.11

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 25, 2022

Changed commit from 04d0344 to a6ab4fa

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 25, 2022

Changed author from Oscar Benjamin to Oscar Benjamin, Matthias Koeppe

@mkoeppe mkoeppe added this to the sage-9.7 milestone Aug 25, 2022
@mkoeppe mkoeppe removed the pending label Aug 25, 2022
@mkoeppe

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 25, 2022

Changed commit from a6ab4fa to 16fdc52

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 25, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

5db5d4eUpdate doctests for SymPy 1.11
16fdc52build/pkgs/sympy: Update to 1.11

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 25, 2022

Reviewer: Matthias Koeppe, ...

@DaveWitteMorris
Copy link
Member

comment:16

I don't see any problems with the upgrade, but I am concerned that sympy is core functionality in symbolics so I wonder if this is too late in the release cycle for adequate testing?

The automated systems do not seem to have successfully tested the ticket. (Do they not have --enable-download-from-upstream-url?) So I ran make testlong on CoCalc (Ubuntu 20.04) and got only two errors, which I think are known, and have nothing to do with this ticket:

sage -t --long --warn-long 81.9 --random-seed=241846751556032050884921104136244529069 src/sage/interfaces/expect.py
**********************************************************************
File "src/sage/interfaces/expect.py", line 937, in sage.interfaces.expect.Expect._eval_line
Failed example:
    singular.interrupt()
Expected:
    True
Got:
    False
**********************************************************************
File "src/sage/interfaces/expect.py", line 943, in sage.interfaces.expect.Expect._eval_line
Failed example:
    singular('2+3')
Expected:
    Singular crashed -- automatically restarting.
    5
Got:
    5

@antonio-rojas
Copy link
Contributor

comment:17

WFM

@antonio-rojas
Copy link
Contributor

Changed reviewer from Matthias Koeppe, ... to Matthias Koeppe, Antonio Rojas

@oscarbenjamin
Copy link

comment:18

I'm planning a SymPy 1.11.1 release imminently after this:
sympy/sympy#23976

I don't know if that affects SAGE but you might want to hold off until that gets released.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 31, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

be00aceMerge tag '9.7.rc0' into t/34118/sympy_1_11
5281574build/pkgs/sympy: Update to 1.11.1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 31, 2022

Changed commit from 16fdc52 to 5281574

@mkoeppe mkoeppe changed the title Update sympy to 1.11 Update sympy to 1.11.1 Aug 31, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 3, 2022

comment:22

Let's get this in please.

@egourgoulhon
Copy link
Member

comment:23

LGTM.

@egourgoulhon
Copy link
Member

Changed reviewer from Matthias Koeppe, Antonio Rojas to Matthias Koeppe, Antonio Rojas, Eric Gourgoulhon

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 5, 2022

comment:24

Thanks!

@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Sep 19, 2022
@vbraun
Copy link
Member

vbraun commented Sep 20, 2022

Changed branch from u/mkoeppe/sympy_1_11 to 5281574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants