Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambdify): make cse=True work with non-lists (1.11 branch) #23976

Merged
merged 3 commits into from
Aug 27, 2022

Conversation

oscarbenjamin
Copy link
Collaborator

@oscarbenjamin oscarbenjamin commented Aug 26, 2022

Co-authored-by: Jason K. Moore moorepants@gmail.com
Co-authored-by: Christopher Smith smichr@gmail.com

References to other Issues or PRs

Backport of #23975 and #23979 to the 1.11 branch.

Bump version to 1.11.1

Brief description of what is fixed or changed

Other comments

Release Notes

  • utilities
    • The 1.11 release introduced a regression when using lambdify with the cse=True option (introduced in 1.9) resulting in a list being returned for a lambdified expression that was not a list. This bug is now fixed in the 1.11.1 release.

Co-authored-by: Jason K. Moore <moorepants@gmail.com>
Co-authored-by: Christopher Smith <smichr@gmail.com>
@sympy-bot
Copy link

sympy-bot commented Aug 26, 2022

Hi, I am the SymPy bot (v167). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • utilities
    • The 1.11 release introduced a regression when using lambdify with the cse=True option (introduced in 1.9) resulting in a list being returned for a lambdified expression that was not a list. This bug is now fixed in the 1.11.1 release. (#23976 by @oscarbenjamin)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.11.1.

Click here to see the pull request description that was parsed.
Co-authored-by: Jason K. Moore <moorepants@gmail.com>
Co-authored-by: Christopher Smith <smichr@gmail.com>

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->

Backport of #23975 and #23979 to the 1.11 branch.

Bump version to 1.11.1

#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* utilities
    * The 1.11 release introduced a regression when using `lambdify` with the `cse=True` option (introduced in 1.9) resulting in a list being returned for a lambdified expression that was not a list. This bug is now fixed in the 1.11.1 release.
<!-- END RELEASE NOTES -->

@github-actions
Copy link

github-actions bot commented Aug 27, 2022

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

       before           after         ratio
     [77f1d79c]       [26f7bdbe]
     <sympy-1.10.1^0>       <sympy-1.11^0>
+     22.9±0.07μs       69.3±0.4μs     3.03  matrices.TimeMatrixExpression.time_MatAdd
+      98.6±0.7ms        178±0.9ms     1.80  sum.TimeSum.time_doit

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

@oscarbenjamin oscarbenjamin merged commit 41d9095 into sympy:1.11 Aug 27, 2022
@oscarbenjamin oscarbenjamin deleted the pr_lambdify_cse_111 branch August 27, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants