Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slight documentation update for modules built upon a FiniteRankFreeModule #34792

Closed
egourgoulhon opened this issue Nov 25, 2022 · 6 comments
Closed

Slight documentation update for modules built upon a FiniteRankFreeModule #34792

egourgoulhon opened this issue Nov 25, 2022 · 6 comments
Labels
c: linear algebra p: major / 3 t: bug
Milestone
sage-9.8

Comments

@egourgoulhon
Copy link
Member

After #34424 (merged in Sage 9.7.rc0), the documentation of TensorFreeModule, ExtPowerFreeModule and ExtPowerDualFreeModule should say that these classes inherit from FiniteRankFreeModule_abstract, not FiniteRankFreeModule.

CC: @mkoeppe

Component: linear algebra

Keywords: tensor

Author: Eric Gourgoulhon

Branch/Commit: fbfb3e2

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/34792
@egourgoulhon egourgoulhon added this to the sage-9.8 milestone Nov 25, 2022
@egourgoulhon
Copy link
Member Author

Branch: public/manifolds/update_documentation_tensor-34792

@egourgoulhon
Copy link
Member Author

New commits:

fbfb3e2Update documentation for modules built upon a FiniteRankFreeModule (#34792)

@egourgoulhon
Copy link
Member Author

Commit: fbfb3e2

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 25, 2022

Reviewer: Matthias Koeppe

@egourgoulhon
Copy link
Member Author

comment:4

Thank you!

@vbraun
Copy link
Member

vbraun commented Dec 11, 2022

Changed branch from public/manifolds/update_documentation_tensor-34792 to fbfb3e2

@vbraun vbraun closed this as completed in 0ead75a Dec 11, 2022
@egourgoulhon egourgoulhon mentioned this issue Jan 30, 2023
Open
kryzar pushed a commit to kryzar/sage that referenced this issue Feb 6, 2023
@egourgoulhon
Update documentation for modules built upon a FiniteRankFreeModule (s…
fbfb3e2 
…agemath#34792)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: linear algebra p: major / 3 t: bug
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@vbraun @egourgoulhon @mkoeppe