-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove direct use of "setup.py sdist", add targets "make SPKG-sdist" #34855
Labels
Milestone
Comments
Commit: |
Dependencies: #34858 |
mkoeppe
changed the title
Remove direct use of "setup.py sdist"
Remove direct use of "setup.py sdist", add targets "make SPKG-sdist"
Dec 19, 2022
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
|
This comment has been minimized.
This comment has been minimized.
Author: Matthias Koeppe |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Removed branch from issue description; replaced by PR #35104 |
mkoeppe
added a commit
to mkoeppe/sage
that referenced
this issue
Feb 17, 2023
vbraun
pushed a commit
that referenced
this issue
Mar 19, 2023
…KG-sdist" <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes #1234" use "Introduce new method to calculate 1+1" --> ### 📚 Description Fixes #34855 <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If it resolves an open issue, please link to the issue here. For example "Closes #1337" --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I have made sure that the title is self-explanatory and the description concisely explains the PR. - [x] I have linked an issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open pull requests that this PR logically depends on --> <!-- - #xyz: short description why this is a dependency - #abc: ... --> URL: #35104 Reported by: Matthias Köppe Reviewer(s): John H. Palmieri
mkoeppe
added a commit
to mkoeppe/sage
that referenced
this issue
May 22, 2023
mkoeppe
added a commit
to mkoeppe/sage
that referenced
this issue
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Direct use of "setup.py sdist" is deprecated. Instead we use
build
to create the sdists.We add new targets
make sagemath_objects-sdist
etc.We move targets
make pypi-sdists
(which now uses the new targets),make wheel
, andmake pypi-wheels
from the top-levelMakefile
tobuild/make/Makefile.in
. This improvesmake pypi-wheels
: It no longer builds the sagemath-objects wheel multiple times (as dependencies of other packages).Depends on #34858
CC: @kiwifb
Component: build
Author: Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/34855
The text was updated successfully, but these errors were encountered: