Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sagelib: Remove unnecessary import of typing_extensions #34859

Closed
mkoeppe opened this issue Dec 19, 2022 · 13 comments
Closed

sagelib: Remove unnecessary import of typing_extensions #34859

mkoeppe opened this issue Dec 19, 2022 · 13 comments
Labels
p: major / 3 t: bug t: refactoring
Milestone
sage-9.8

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 19, 2022

see also #34831

CC: @EnderWannabe @fchapoton @jhpalmieri

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 39bd748

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/34859
@mkoeppe mkoeppe added this to the sage-9.8 milestone Dec 19, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 19, 2022

Branch: u/mkoeppe/sagelib__remove_unnecessary_import_of_typing_extensions

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 19, 2022

New commits:

2c87163src/sage/dynamics/arithmetic_dynamics/projective_ds.py: Remove unused import of typing_extensions

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 19, 2022

Commit: 2c87163

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 19, 2022

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 19, 2022

Changed commit from 2c87163 to 7b3c972

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 19, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

ef75d6asrc/MANIFEST.in: Add pxd files etc
2f4b053pkgs/sagemath-standard/setup.py: Run finder also for sdist, egg_info, dist_info
00deebepkgs/sagemath-objects/setup.py: Run finder also for sdist, egg_info, dist_info
7b3c972Merge #34859

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 19, 2022

Changed commit from 7b3c972 to 39bd748

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 19, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

39bd748src/sage/dynamics/arithmetic_dynamics/projective_ds.py: Remove unused import of typing_extensions

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@jhpalmieri
Copy link
Member

comment:6

Looks good to me.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 23, 2022

comment:7

Thank you!

@vbraun
Copy link
Member

vbraun commented Jan 12, 2023

Changed branch from u/mkoeppe/sagelib__remove_unnecessary_import_of_typing_extensions to 39bd748

@vbraun vbraun closed this as completed in df74efb Jan 12, 2023
kryzar pushed a commit to kryzar/sage that referenced this issue Feb 6, 2023
@mkoeppe
Merge sagemath#34859
e229436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: bug t: refactoring
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@vbraun @jhpalmieri @mkoeppe