set reverse=True by default in basis_for_quaternion_lattice() #34880
Labels
Milestone
Comments
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
This was referenced Jan 10, 2023
|
Removed branch from issue description, it is replaced by PR #34962 |
vbraun
pushed a commit
that referenced
this issue
Feb 12, 2023
…group_theory.rst Part of #32544: {{{ sage -t --long --random-seed=185470747385175316039405094141387664605 src/doc/en/thematic_tutorials/group_theory.rst ********************************************************************** File "src/doc/en/thematic_tutorials/group_theory.rst", line 207, in doc.en.thematic_tutorials.group_theory Failed example: euler_phi(m*n) == euler_phi(m) * euler_phi(n) Expected: True Got: False ********************************************************************** 1 item had failures: 1 of 170 in doc.en.thematic_tutorials.group_theory [127 tests, 1 failure, 4.40 s] }}} (From a patchbot run in #34880.) URL: https://trac.sagemath.org/34901 Reported by: lorenz Ticket author(s): Frédéric Chapoton Reviewer(s): Lorenz Panny
yyyyx4
added a commit
to yyyyx4/sage
that referenced
this issue
May 26, 2023
vbraun
pushed a commit
that referenced
this issue
Jun 3, 2023
Per #34962 (comment), we should first issue deprecation warnings for the change suggested in #34880. URL: #35683 Reported by: Lorenz Panny Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Aug 27, 2024
…_lattice()
Fixes sagemath#34880.
URL: sagemath#34962
Reported by: Lorenz Panny
Reviewer(s): Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
reverse=Trueflag is recommended (and set by default) for quaternion orders, but I think it is also the better choice for all other quaternion lattices: Among other things, settingreverse=Truemakes the returned basis contain the norm of an ideal (very usefully generalizing the fact that the returned basis for an order contains1).Component: algebra
Author: Lorenz Panny
Issue created by migration from https://trac.sagemath.org/ticket/34880
The text was updated successfully, but these errors were encountered: