Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changing some Cannot to cannot #34944

Closed
fchapoton opened this issue Jan 27, 2023 · 9 comments · Fixed by #35007
Closed

changing some Cannot to cannot #34944

fchapoton opened this issue Jan 27, 2023 · 9 comments · Fixed by #35007
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-10.0

Comments

@fchapoton
Copy link
Contributor

fchapoton commented Jan 27, 2023 •
edited by mkoeppe
Loading

in the error messages, to follow standard python practice

Component: refactoring

Author: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/34944
@fchapoton fchapoton added this to the sage-9.8 milestone Jan 27, 2023
@fchapoton
Copy link
Contributor Author

New commits:

3723f2dchanging some Cannot to cannot in error messages

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34944

@fchapoton
Copy link
Contributor Author

Commit: 3723f2d

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 27, 2023

comment:2

many doctest failures

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 27, 2023

Changed commit from 3723f2d to d7af60d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 27, 2023

Branch pushed to git repo; I updated commit sha1. New commits:

d7af60dsome fixes

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 27, 2023

Branch pushed to git repo; I updated commit sha1. New commits:

4a5a470more fixes

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 27, 2023

Changed commit from d7af60d to 4a5a470

@mkoeppe mkoeppe removed this from the sage-9.8 milestone Jan 29, 2023
@fchapoton fchapoton mentioned this issue Feb 7, 2023
Merged
@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 13, 2023

Removed branch from issue description; replaced by PR #35007

@vbraun vbraun closed this as completed in ea2c228 Feb 24, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging a pull request may close this issue.

Fix some cannot fchapoton/sage
2 participants
@fchapoton @mkoeppe