Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some cannot #35007

Merged
merged 5 commits into from
Feb 24, 2023
Merged

Fix some cannot #35007

merged 5 commits into from
Feb 24, 2023

Conversation

fchapoton
Copy link
Contributor

Fix #34944

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023

Codecov Report

Base: 88.59% // Head: 88.59% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (e730294) compared to base (f21094e).
Patch coverage: 50.00% of modified lines in pull request are covered.

❗ Current head e730294 differs from pull request most recent head 504c6e8. Consider uploading reports for the commit 504c6e8 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35007      +/-   ##
===========================================
- Coverage    88.59%   88.59%   -0.01%     
===========================================
  Files         2136     2136              
  Lines       396141   396141              
===========================================
- Hits        350952   350943       -9     
- Misses       45189    45198       +9     
Impacted Files Coverage Δ
src/sage/combinat/alternating_sign_matrix.py 98.12% <0.00%> (ø)
src/sage/combinat/decorated_permutation.py 92.18% <0.00%> (ø)
src/sage/combinat/derangements.py 94.87% <0.00%> (ø)
src/sage/geometry/lattice_polytope.py 92.92% <0.00%> (ø)
src/sage/geometry/polyhedron/parent.py 90.78% <0.00%> (ø)
src/sage/rings/asymptotic/asymptotic_ring.py 94.34% <ø> (ø)
...rc/sage/rings/polynomial/multi_polynomial_ideal.py 82.13% <0.00%> (ø)
src/sage/rings/universal_cyclotomic_field.py 97.77% <ø> (ø)
src/sage/schemes/generic/ambient_space.py 93.22% <0.00%> (ø)
src/sage/rings/number_field/number_field.py 93.59% <100.00%> (ø)
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kwankyu kwankyu added this to the sage-9.9 milestone Feb 8, 2023
@vbraun vbraun merged commit ea2c228 into sagemath:develop Feb 24, 2023
@fchapoton fchapoton deleted the fix_some_cannot branch July 16, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

changing some Cannot to cannot
6 participants