Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage.{algebras,combinat,matroids}: Replace imports from sage.*.all for namespace packages #34946

Closed
mkoeppe opened this issue Jan 29, 2023 · 16 comments · Fixed by #35090
Closed

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 29, 2023

Using ./sage -fiximports from #34945.

Also remove trailing whitespace in the affected files.

Part of Meta-ticket #32414

CC: @alexchandler100 @fchapoton @tscrim

Component: refactoring

Author: Alex Chandler, Matthias Koeppe

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34946

@mkoeppe mkoeppe added this to the sage-9.8 milestone Jan 29, 2023
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 29, 2023

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 29, 2023

Commit: bdf2f33

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 29, 2023

New commits:

bdf2f33sage -fiximports src/sage/algebras src/sage/combinat src/sage/matroids

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 29, 2023

comment:5

Lint and Build&Test failures are unrelated.

@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 29, 2023
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2023

Changed commit from bdf2f33 to bd50b49

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2023

Branch pushed to git repo; I updated commit sha1. New commits:

bd50b49git grep -l -E ' (Q as QQ|Z as ZZ)' | xargs sed -i.bak 's/ Q as QQ/ QQ/;s/ Z as ZZ/ ZZ/;'

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2023

Branch pushed to git repo; I updated commit sha1. New commits:

8e77597sage.{algebras,combinat}: Consolidate imports from the same module

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2023

Changed commit from bd50b49 to 8e77597

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 30, 2023

Changed author from Alex Chandler to Alex Chandler, Matthias Koeppe

@tscrim
Copy link
Collaborator

tscrim commented Jan 30, 2023

comment:10

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Jan 30, 2023

Reviewer: Travis Scrimshaw

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 30, 2023

comment:11

Thanks!

@vbraun
Copy link
Member

vbraun commented Feb 12, 2023

Merge conflict, please open GitHub PR to fix

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 12, 2023

Removed the branch from the issue description; replaced by PR #35090

mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
@vbraun vbraun closed this as completed in b0df140 Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants