Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.plot.animate: Use Executable.absolute_filename, pass configured FFMPEG via sage-conf #35255

Closed
beew opened this issue Mar 10, 2023 · 1 comment · Fixed by #37312
Closed

sage.plot.animate: Use Executable.absolute_filename, pass configured FFMPEG via sage-conf #35255

beew opened this issue Mar 10, 2023 · 1 comment · Fixed by #37312
Labels
c: build: configure
Milestone
sage-10.4

Comments

@beew
Copy link

beew commented Mar 10, 2023 •
edited by mkoeppe
Loading

Part of:

Original issue description:

I have compiled sage with a local version of ffmpeg successfully by issuing these commands before running configure

export PATH="$HOME/opt/ffmpeg6/bin:$PATH"
export LD_LIBRARY_PATH="$HOME/opt/ffmpeg6/lib:$LD_LIBRARY_PATH"
export PKG_CONFIG_PATH="$HOME/opt/ffmpeg6/lib/pkgconfig:$PKG_CONFIG_PATH"

Now I would like to make sure that sage respects these environmental variables at run time. Should I put them in .sage/sagerc?

Running sage --sh, I found these two environmental variables

SAGE_ORIG_PATH

SAGE_ORIG_PATH_SET

I am trying to find some documentation on these but can't find any. Can someone explain to me what these are?

OS is Ubuntu 22.04, sage 9.8
@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 11, 2023

SAGE_ORIG_PATH is no longer in use in the runtime environment. It has a limited use during the build.

Sage does not have the mechanism that you are looking for.

If you want ffmpeg in your PATH, you will have to set PATH in your ~/.profile or ~/.bashrc etc.; or symlink it into a directory that is in PATH. Likewise with LD_LIBRARY_PATH (if setting this is actually needed).

PKG_CONFIG_PATH is not needed at runtime.

@mkoeppe mkoeppe changed the title compile sage with customized system lib sage.plot.animate: Use Executable.absolute_filename, pass configured FFMPEG via sage-conf Mar 11, 2023
vbraun pushed a commit to vbraun/sage that referenced this issue Jun 10, 2024
sagemathgh-37312: sage.plot.animate: Use FFmpeg.absolute_filename; …
611f93d 
…`sage.features`: Remove deprecated methods

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
- Fixes sagemath#35255

Removes methods deprecated in:
- sagemath#31292 (2022)
- sagemath#33114 (2022)
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#37312
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this issue Jun 16, 2024
sagemathgh-37312: sage.plot.animate: Use FFmpeg.absolute_filename; …
1f9b310 
…`sage.features`: Remove deprecated methods

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
- Fixes sagemath#35255

Removes methods deprecated in:
- sagemath#31292 (2022)
- sagemath#33114 (2022)
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#37312
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this issue Jun 16, 2024
sagemathgh-37312: sage.plot.animate: Use FFmpeg.absolute_filename; …
f7d10ce 
…`sage.features`: Remove deprecated methods

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
- Fixes sagemath#35255

Removes methods deprecated in:
- sagemath#31292 (2022)
- sagemath#33114 (2022)
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#37312
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
@vbraun vbraun closed this as completed in 8110dc5 Jun 22, 2024
@mkoeppe mkoeppe added this to the sage-10.4 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build: configure
Projects
None yet
Milestone
sage-10.4
2 participants
@beew @mkoeppe