-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qqbar.clear_denominators: crude but fast alternative algorithm #34961
Conversation
Codecov ReportBase: 88.59% // Head: 88.59% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## develop #34961 +/- ##
========================================
Coverage 88.59% 88.59%
========================================
Files 2136 2136
Lines 396141 396143 +2
========================================
+ Hits 350964 350978 +14
+ Misses 45177 45165 -12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
for f, e in factors.items(): | ||
change = change * f**e | ||
denoms = [c.denominator() for c in poly] | ||
if all(d.nbits() < 128 for d in denoms): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is 128
just a random threshold?
On Monday, 6 February 2023 23:33:39 CET Vincent Delecroix wrote:
Is `128` just a random threshold?
Basically yes (small enough that integer factoring is fast).
…--
Marc
|
7eaeab6
to
9cc8d1a
Compare
9cc8d1a
to
4d08c4d
Compare
Thanks! |
Fixes #33810.