-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate constructing number-field fractional ideals via orders' .ideal() method #34979
Conversation
Codecov ReportBase: 88.57% // Head: 88.58% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #34979 +/- ##
===========================================
+ Coverage 88.57% 88.58% +0.01%
===========================================
Files 2140 2136 -4
Lines 397273 396154 -1119
===========================================
- Hits 351891 350945 -946
+ Misses 45382 45209 -173
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
f30b8fc
to
b36af1b
Compare
According to the logs there was one failing doctest, in |
Documentation preview for this PR is ready! 🎉 |
Thank you! |
Fixes #34806.