-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add .torsion_basis() method to EllipticCurve_finite_field #34982
add .torsion_basis() method to EllipticCurve_finite_field #34982
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #34982 +/- ##
==========================================
Coverage ? 88.59%
==========================================
Files ? 2136
Lines ? 396146
Branches ? 0
==========================================
Hits ? 350952
Misses ? 45194
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There are failing tests, but otherwise this looks good to me. |
c9badc3
to
efb609f
Compare
The test failure is unrelated to the changes here. See #35017. |
efb609f
to
110d9bf
Compare
Looks good to me and tests do now pass -- @roed314 can you do a positive review and change the label accordingly? (I can do the latter, but you are the official reviewer.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Fixes #34718.