-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new skew hadamard matrices #34985
Add new skew hadamard matrices #34985
Conversation
@wdjoyner - you might look at the freshly built docs here: https://deploy-preview-35059--sagemath-tobias.netlify.app/ |
by the way, for |
this is a rebase over sagemath#34985
PDF docs don't build |
our usual unicode hiccup:
|
So this needs yet another |
I don't know how to fix this in a regular way; i.e. I added --- a/src/sage_docbuild/conf.py
+++ b/src/sage_docbuild/conf.py
@@ -620,6 +620,7 @@ latex_elements['preamble'] = r"""
\DeclareUnicodeCharacter{256E}{+}
\DeclareUnicodeCharacter{256F}{+}
\DeclareUnicodeCharacter{2570}{+}
+ \DeclareUnicodeCharacter{030C}{\v{c}} % č
\fi
\let\textLaTeX\LaTeX but it had no effect. Am I missing something, @vbraun ? |
hmm, |
trying to use |
@jhpalmieri - have you seen this sort of trouble before? How about switching to |
with the last change, it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are two ways to get caron-accented characters in Unicode - we must you the one that encodes it as one unicode characater, not two. This is fixed now.
It sounds like this has been resolved, but I'll reply anyway. I've never used |
Documentation preview for this PR is ready! 🎉 |
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes #1234" use "Introduce new method to calculate 1+1" --> ### 📚 Description Added new construction for (non skew) Hadamard matrices of order up to 1000. The only orders <1000 for which no construction is known are 668, 716, 892. In particular, the following has been changed: - Added more Williamson type matrices (the way these matrices are stored has been changed to be more compact) - Implemented a function to construct non-skew Supplementary difference Sets, as well as a function to construct Hadamard matrices from these sets - Added Miyamoto construction Note that only commits starting from 15e1b50 are new, the previous ones where created in #34985. <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If it resolves an open issue, please link to the issue here. For example "Closes #1337" --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I have made sure that the title is self-explanatory and the description concisely explains the PR. - [x] I have linked an issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open pull requests that this PR logically depends on --> <!-- - #xyz: short description why this is a dependency - #abc: ... --> URL: #35059 Reported by: MatteoCati Reviewer(s): david joyner, Dima Pasechnik
Fixes #34848.