Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #34949: sage.{categories,matrix,structure}: Replace imports from sage.*.all for namespace packages #35012

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Feb 7, 2023

Closes #34949

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023

Codecov Report

Base: 88.59% // Head: 88.58% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (d905cc3) compared to base (05329f6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35012      +/-   ##
===========================================
- Coverage    88.59%   88.58%   -0.02%     
===========================================
  Files         2140     2140              
  Lines       396998   397006       +8     
===========================================
- Hits        351740   351700      -40     
- Misses       45258    45306      +48     
Impacted Files Coverage Δ
src/sage/categories/category.py 98.01% <ø> (ø)
src/sage/docs/instancedoc.py 0.00% <ø> (ø)
src/sage/env.py 88.00% <ø> (ø)
src/sage/misc/cython.py 70.35% <ø> (ø)
src/sage/misc/sageinspect.py 80.81% <ø> (ø)
src/sage/misc/superseded.py 99.01% <ø> (ø)
src/sage/categories/bialgebras.py 100.00% <100.00%> (ø)
src/sage/categories/chain_complexes.py 93.02% <100.00%> (+0.34%) ⬆️
src/sage/categories/coalgebras.py 100.00% <100.00%> (ø)
src/sage/categories/coalgebras_with_basis.py 97.77% <100.00%> (+0.10%) ⬆️
... and 51 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests fail with

sage -t --random-seed=119552442577065273759575227667889303090 sage/structure/element.pyx  # 6 doctests failed

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 8, 2023

I've fixed this and updated all other uses as well. Let's see what Build&Test has to say now.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 8, 2023

Turns out the placement of # optional tags was not to blame, after all, it was just a bad import. But I'm glad I made these changes; I also fixed some missing # optional tags for follow-up lines in doctests.

Copy link
Contributor

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll leave this at "needs review" as someone else might want to have a look at it. Feel free to set it to "positive review" in a week or so.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 9, 2023

Thank you!

@mkoeppe mkoeppe self-assigned this Feb 18, 2023
…tegories_matrix_structure___replace_imports_from_sage___all_for_namespace_packages
@mkoeppe mkoeppe added this to the sage-10.0 milestone Feb 19, 2023
@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: d905cc3

@vbraun vbraun merged commit cf49215 into sagemath:develop Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sage.{categories,matrix,structure}: Replace imports from sage.*.all for namespace packages
5 participants