Implement check for Lorentzian polynomials #28252 #35021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements methods for univariate and multivariate polynomials to check whether a polynomial is Lorentzian. A helper function checks whether a collection of integer lattice points is M-convex. Additionally extends the constructor for class QuadraticForm to accept as input a homogeneous polynomial of degree two.
Added literature references to the doctests, and added a new flag to the is_lorentzian_polynomial method, give_reason, which causes the method to return a tuple containing the boolean output of the function, and if this is false, a string explaining why the polynomial is not Lorentzian.
Ticket 28252 was created in July, 2019 at Sage Days 99 in Minneapolis, and was left in completed form but never got reviewed for inclusion in Sage. The branch got out of sync after a few months, so this branch rebases the work from the project on the most recent release of the develop branch. Only minor changes were needed in the merge, so the code should be ready for review again.
tscrim
requested changes
Feb 10, 2023
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
Codecov ReportBase: 88.59% // Head: 88.59% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #35021 +/- ##
===========================================
- Coverage 88.59% 88.59% -0.01%
===========================================
Files 2136 2136
Lines 396142 396159 +17
===========================================
+ Hits 350948 350960 +12
- Misses 45194 45199 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. β View full report at Codecov. |
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
tscrim
approved these changes
Feb 11, 2023
tscrim
approved these changes
Feb 11, 2023
|
Sorry, GH has random buttons and doesn't explain what they do (with no mouse hover text...). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28252
π Description
π Checklist
β Dependencies