Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document argument is_open in ManifoldSubset.complement and difference #35040

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

egourgoulhon
Copy link
Member

📚 Document argument is_open of methods complement and difference in ManifoldSubset

The argument is_open was not documented in the docstrings of ManifoldSubset.complement and ManifoldSubset.difference

📝 Checklist

  • [x ] I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • [ x] I have created tests covering the changes.
  • [ x] I have updated the documentation accordingly.

⌛ Dependencies

@egourgoulhon egourgoulhon changed the title Document argument is_open in ManifoldSubset.complement and differnce Document argument is_open in ManifoldSubset.complement and difference Feb 9, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 88.59% // Head: 88.59% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (f02b32b) compared to base (104dde9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #35040   +/-   ##
========================================
  Coverage    88.59%   88.59%           
========================================
  Files         2136     2136           
  Lines       396142   396142           
========================================
+ Hits        350948   350963   +15     
+ Misses       45194    45179   -15     
Impacted Files Coverage Δ
src/sage/manifolds/subset.py 94.19% <ø> (ø)
src/sage/rings/polynomial/pbori/parallel.py 59.82% <0.00%> (-1.79%) ⬇️
src/sage/modular/hecke/algebra.py 94.65% <0.00%> (-1.07%) ⬇️
src/sage/categories/weyl_groups.py 96.47% <0.00%> (-0.59%) ⬇️
src/sage/modular/arithgroup/congroup_gamma0.py 94.41% <0.00%> (-0.56%) ⬇️
src/sage/graphs/generic_graph.py 89.04% <0.00%> (-0.50%) ⬇️
src/sage/modular/overconvergent/hecke_series.py 98.76% <0.00%> (-0.31%) ⬇️
src/sage/graphs/generators/random.py 91.95% <0.00%> (-0.18%) ⬇️
src/sage/graphs/digraph.py 92.58% <0.00%> (-0.13%) ⬇️
src/sage/schemes/elliptic_curves/ell_point.py 84.51% <0.00%> (-0.12%) ⬇️
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egourgoulhon
Copy link
Member Author

Thank you Tobias for the review!

@egourgoulhon
Copy link
Member Author

Thank you Matthias for the review!

@vbraun vbraun merged commit 2cbf029 into sagemath:develop Mar 13, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants