Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes about recent changes on KnotInfo #35063

Merged
merged 3 commits into from
Mar 13, 2023

Conversation

soehms
Copy link
Member

@soehms soehms commented Feb 10, 2023

📚 Description

This is a follow up of #33969, which used the Khovanov polynomial KnotInfo data in a new conversion method. Unfortunately, this data has since been removed from the website (but not from the database).

This PR merely adds appropriate notes to the documentation of the KnotInfo interface module.

Since the missing data may cause confusion, it would be great if the notes will be included in release 9.8.

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2023

Codecov Report

Base: 88.59% // Head: 88.58% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (82dc8d6) compared to base (fbb4127).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35063      +/-   ##
===========================================
- Coverage    88.59%   88.58%   -0.01%     
===========================================
  Files         2140     2140              
  Lines       396961   396961              
===========================================
- Hits        351677   351653      -24     
- Misses       45284    45308      +24     
Impacted Files Coverage Δ
src/sage/knots/knotinfo.py 83.30% <ø> (ø)
src/sage/interfaces/qsieve.py 71.30% <0.00%> (-2.61%) ⬇️
...e/combinat/cluster_algebra_quiver/mutation_type.py 51.78% <0.00%> (-1.19%) ⬇️
src/sage/schemes/elliptic_curves/hom_velusqrt.py 94.09% <0.00%> (-0.79%) ⬇️
src/sage/sets/integer_range.py 91.41% <0.00%> (-0.51%) ⬇️
src/sage/rings/polynomial/ore_polynomial_ring.py 89.40% <0.00%> (-0.43%) ⬇️
src/sage/combinat/constellation.py 91.18% <0.00%> (-0.41%) ⬇️
src/sage/modular/arithgroup/arithgroup_perm.py 92.57% <0.00%> (-0.38%) ⬇️
src/sage/modular/overconvergent/hecke_series.py 98.76% <0.00%> (-0.31%) ⬇️
src/sage/graphs/graph_plot.py 84.33% <0.00%> (-0.29%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Feb 11, 2023
@soehms soehms force-pushed the add_note_to_knotinfo_interface branch from 0eb6a3f to 9e3ebef Compare February 13, 2023 07:54
@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: 82dc8d6

Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@soehms
Copy link
Member Author

soehms commented Feb 20, 2023

LGTM!

Thanks!

@vbraun vbraun merged commit 788415e into sagemath:develop Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants