-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move single_valued method of MZV to auxiliary F ring #35086
Conversation
Codecov ReportBase: 88.59% // Head: 88.59% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #35086 +/- ##
=========================================
Coverage 88.59% 88.59%
=========================================
Files 2140 2136 -4
Lines 396961 396143 -818
=========================================
- Hits 351677 350975 -702
+ Misses 45284 45168 -116
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Could you be more explicit in the documentation about the mathematical meaning of |
|
||
sage: from sage.modular.multiple_zeta_F_algebra import F_algebra | ||
sage: F = F_algebra(QQ) | ||
sage: t = 4*F("2")+F("3") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why no space around *
and +
?
wtf ? I have first pulled develop, and now this is a mess.. |
Looks good to me. I did not understand the purpose of merging develop. |
This was my workflow, when develop was not a moving target. I was always working on top of the latest develop. I guess I have to adapt, but it's not clear to me how. |
if you want to do that you would better do a rebase rather than a merge. |
8471298
to
875738a
Compare
Documentation preview for this PR is ready! 🎉 |
would you please "approve" the changes ? |
📚 Description
This is moving a little piece of code from MZV to a more proper place (auxiliary ring).
📝 Checklist
⌛ Dependencies