-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Use enum for face iterator status #35087
refactor: Use enum for face iterator status #35087
Conversation
Codecov ReportBase: 88.59% // Head: 88.59% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #35087 +/- ##
===========================================
- Coverage 88.59% 88.59% -0.01%
===========================================
Files 2140 2140
Lines 396998 396961 -37
===========================================
- Hits 351740 351670 -70
- Misses 45258 45291 +33
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you. |
Documentation preview for this PR is ready! 🎉 |
📚 Description
Related to the feature request in #34773, I'm trying to make my own code a bit more readable.
Here we replace the int representing the status of the face of the iterator by an enumerator. This allows understanding this variable without having to look up the meaning.
📝 Checklist
⌛ Dependencies