Simplicial set group #35097
Merged
Simplicial set group #35097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #35097 +/- ##
===========================================
+ Coverage 88.60% 88.62% +0.01%
===========================================
Files 2136 2148 +12
Lines 396142 398732 +2590
===========================================
+ Hits 350990 353361 +2371
- Misses 45152 45371 +219
... and 159 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
jhpalmieri
reviewed
Mar 15, 2023
jhpalmieri
reviewed
Mar 15, 2023
jhpalmieri
reviewed
Mar 15, 2023
| def _universal_cover_dict(self): | ||
| r""" | ||
| Return the fundamental group and dictionary sending each edge to | ||
| the corresponding group element |
jhpalmieri
reviewed
Mar 15, 2023
| (f * f * f, e): ((f * f, 1), s_0 (f, e), s_1 (f, e), (f * f, e))} | ||
| sage: C.fundamental_group() | ||
| Finitely presented group < | > | ||
|
|
There was a problem hiding this comment.
I suggest deleting these two blank lines.
jhpalmieri
requested changes
Mar 15, 2023
Co-authored-by: John H. Palmieri <jhpalmieri64@gmail.com>
Co-authored-by: John H. Palmieri <jhpalmieri64@gmail.com>
|
Thanks for the review. I did the suggested changes. |
|
Looks great, thank you! |
jhpalmieri
approved these changes
Mar 15, 2023
|
Documentation preview for this PR is ready! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Implementation of finite covers of simplicial sets
Compute the cover of a (based) simplicial set associated to a representation of its fundamental group to a finite group.
Fixes #34886.
📝 Checklist
⌛ Dependencies