Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox.ini (fedora-33): Do not set IGNORE_MISSING_SYSTEM_PACKAGES=no #35126

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Feb 14, 2023

📚 Description

fedora-33-maximal fails because one of our optional packages is missing.
https://github.com/mkoeppe/sage/actions/runs/4158995778/jobs/7212691967
We fix it by ignoring the absence of packages for this configuration, like we do for earlier versions of fedora.

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: ac3c0e9

@codecov-commenter
Copy link

Codecov Report

Base: 88.58% // Head: 88.59% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (ac3c0e9) compared to base (293dd72).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #35126   +/-   ##
========================================
  Coverage    88.58%   88.59%           
========================================
  Files         2140     2140           
  Lines       396961   396961           
========================================
+ Hits        351655   351680   +25     
+ Misses       45306    45281   -25     
Impacted Files Coverage Δ
src/sage/groups/affine_gps/euclidean_group.py 88.88% <0.00%> (-11.12%) ⬇️
src/sage/groups/affine_gps/affine_group.py 96.62% <0.00%> (-2.25%) ⬇️
src/sage/groups/additive_abelian/qmodnz.py 91.48% <0.00%> (-2.13%) ⬇️
src/sage/combinat/posets/poset_examples.py 87.67% <0.00%> (-1.01%) ⬇️
src/sage/quadratic_forms/ternary_qf.py 66.73% <0.00%> (-0.59%) ⬇️
src/sage/sets/integer_range.py 91.41% <0.00%> (-0.51%) ⬇️
src/sage/modular/arithgroup/arithgroup_perm.py 92.57% <0.00%> (-0.38%) ⬇️
src/sage/graphs/generators/random.py 92.12% <0.00%> (-0.18%) ⬇️
src/sage/rings/function_field/ideal.py 89.47% <0.00%> (-0.17%) ⬇️
src/sage/schemes/elliptic_curves/ell_generic.py 93.23% <0.00%> (-0.14%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dimpase dimpase merged commit 84eebf0 into sagemath:develop Feb 14, 2023
@dimpase
Copy link
Member

dimpase commented Feb 14, 2023

this is a pure CI infrastructure, so it can do in now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants