Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more standard shape for error messages in combinat #35252

Merged
merged 2 commits into from
Apr 1, 2023

Conversation

fchapoton
Copy link
Contributor

📚 Description

This changes most (but not all) error messages in combinat/ to conform to the Python convention (no capital, no final dot)

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2023

Codecov Report

Patch coverage: 86.76% and project coverage change: +0.01 🎉

Comparison is base (52a81cb) 88.57% compared to head (0e3557b) 88.59%.

❗ Current head 0e3557b differs from pull request most recent head 7688b96. Consider uploading reports for the commit 7688b96 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35252      +/-   ##
===========================================
+ Coverage    88.57%   88.59%   +0.01%     
===========================================
  Files         2140     2140              
  Lines       397273   397415     +142     
===========================================
+ Hits        351891   352078     +187     
+ Misses       45382    45337      -45     
Impacted Files Coverage Δ
src/sage/combinat/binary_tree.py 97.08% <0.00%> (ø)
src/sage/combinat/combinat.py 93.57% <0.00%> (ø)
src/sage/combinat/combinatorial_map.py 94.11% <0.00%> (ø)
src/sage/combinat/composition.py 97.37% <0.00%> (ø)
src/sage/combinat/constellation.py 91.59% <0.00%> (+0.40%) ⬆️
src/sage/combinat/e_one_star.py 90.84% <0.00%> (ø)
src/sage/combinat/fully_packed_loop.py 96.03% <ø> (ø)
src/sage/combinat/interval_posets.py 93.93% <ø> (ø)
src/sage/combinat/parallelogram_polyomino.py 97.08% <0.00%> (ø)
src/sage/combinat/partition.py 96.88% <0.00%> (ø)
... and 64 more

... and 27 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: 7688b96

Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The test failure (a timeout) is unrelated.

@vbraun vbraun merged commit 936979b into sagemath:develop Apr 1, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 1, 2023
@fchapoton fchapoton deleted the error_messages_combinat branch July 16, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants