fixing most of pycodestyle E271 in pyx files #35312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #35312 +/- ##
========================================
Coverage 88.62% 88.62%
========================================
Files 2148 2148
Lines 398855 398855
========================================
+ Hits 353480 353481 +1
+ Misses 45375 45374 -1 see 29 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
mkoeppe
reviewed
Mar 20, 2023
dcoudert
approved these changes
Mar 20, 2023
| return (a*b).is_square( root = False ) | ||
| is_sqr, sq_rt = (a*b).is_square( root = True ) | ||
| return (a * b).is_square(root=False) | ||
| is_sqr, sq_rt = ( a *b).is_square(root=True) |
|
Documentation preview for this PR is ready! 🎉 |
|
Merge conflict |
fchapoton
force-pushed
the
fixing_most_E271_pyx
branch
from
09b7f9d
to
0884b80
Compare
|
setting back to positive after easy rebasing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
This is fixing most of pycodestyle E271 in pyx files.
There remains a bunch in rings/polynomials.
📝 Checklist
⌛ Dependencies