Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monotile to polgyon examples #35331

Merged
merged 6 commits into from
Apr 6, 2023
Merged

Conversation

mo271
Copy link
Contributor

@mo271 mo271 commented Mar 22, 2023

This adds an aperiodic monotile to the many examples in the documentation of the polygon2d function. https://arxiv.org/abs/2303.10798

📚 Description

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

This adds an aperiodic monotile to the many examples in the documentation of the `polygon2d` function. 
https://arxiv.org/abs/2303.10798
@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 22, 2023

Nice. Add the reference to the doc?

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (c00e6c2) 88.62% compared to head (e9e52ea) 88.61%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35331      +/-   ##
===========================================
- Coverage    88.62%   88.61%   -0.02%     
===========================================
  Files         2148     2148              
  Lines       398855   398855              
===========================================
- Hits        353480   353435      -45     
- Misses       45375    45420      +45     
Impacted Files Coverage Δ
src/sage/plot/polygon.py 97.72% <ø> (ø)

... and 25 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: e9e52ea

@vbraun vbraun merged commit 4134050 into sagemath:develop Apr 6, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants