-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve performance of stream cauchy invert #35338
improve performance of stream cauchy invert #35338
Conversation
…ac.sagemath.org:sage into t/34553/improve_performance_of_stream_cauchy_invert
…th.org:sage into t/34553/improve_performance_of_stream_cauchy_invert
…th.org:sage into t/34553/improve_performance_of_stream_cauchy_invert
Warning: there is another commit, which removed I am not sure what to make of this. Also, in the We would have to check whether the modifications here are really an improvement. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #35338 +/- ##
===========================================
- Coverage 88.61% 88.61% -0.01%
===========================================
Files 2148 2148
Lines 398855 398913 +58
===========================================
+ Hits 353438 353488 +50
- Misses 45417 45425 +8
... and 28 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
We got rid of it because we realized that the Cauchy inverse always had to compute things in order, so it was always dense. Thus, any changes need to be in |
Ah, excellent that you remember / are pointing this out! I don't know yet when I can continue working on this, but all your comments so far are very helpful, thank you! |
I will try to look at this again soon too to try and see what speedups can be done, but it will probably not be a high priority for me. |
… of https://github.com/mantepse/sage into improve_performance
Documentation preview for this PR (built with commit 1d52328; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
📚 Description
Replace loops by sums with lazy assignments and provide a dedicated
get_coefficient
forStream_cauchy_invert
Fixes #34553
📝 Checklist
⌛ Dependencies