Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/tox.ini: Add cython-lint #35385

Merged
merged 5 commits into from
Apr 6, 2023
Merged

src/tox.ini: Add cython-lint #35385

merged 5 commits into from
Apr 6, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Mar 29, 2023

📚 Description

Adding the command sage --tox -e cython-lint.
See https://pypi.org/project/cython-lint/

There are many failures, so it is not run by default.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Mar 29, 2023
@fchapoton
Copy link
Contributor

ERROR: /__w/sage/sage/src/tox.ini:200: duplicate name 'description'

@fchapoton
Copy link
Contributor

and the doc does not build

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 30, 2023

@fchapoton chapoton Should we also add a "cython-lint-minimal" that would be run automatically?

@fchapoton
Copy link
Contributor

fchapoton commented Mar 30, 2023

There is no urgency. I see no way among the command-line options to select a subset of checks. It seems that one can only ignore some checks.

Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 30, 2023

Thanks!

@vbraun vbraun merged commit ef873e1 into sagemath:develop Apr 6, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants