-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement the depth of a quasimodular form #35517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes (just "homogeneous" is correct, unless what you wrote has a special meaning, but I don't think so?). Feel free to reject the suggestions
Otherwise looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be the final change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you :)
Documentation preview for this PR (built with commit 97286da; changes) is ready! 🎉 |
Thank you for reviewing my PRs! |
📚 Description
This PR implements the depth of a quasimodular form. Recall that the depth of a quasimodular form$f$ of weight $k$ is the integer $p$ such that:
where$f_i$ is of weight $k - 2*i$ and $f_p\neq 0$ .
CC: @videlec
📝 Checklist
⌛ Dependencies