Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement the depth of a quasimodular form #35517

Merged
merged 8 commits into from
Mar 25, 2024
Merged

Conversation

DavidAyotte
Copy link
Member

📚 Description

This PR implements the depth of a quasimodular form. Recall that the depth of a quasimodular form $f$ of weight $k$ is the integer $p$ such that:

$$ f = f_0 + f_1 E_2 + \cdots + f_p E_2^p $$

where $f_i$ is of weight $k - 2*i$ and $f_p\neq 0$.

CC: @videlec

📝 Checklist

  • [ x] The title is concise, informative, and self-explanatory.
  • [x ] The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion. (not applicable)
  • [x ] I have created tests covering the changes.
  • [x ] I have updated the documentation accordingly.

⌛ Dependencies

Copy link
Contributor

@grhkm21 grhkm21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes (just "homogeneous" is correct, unless what you wrote has a special meaning, but I don't think so?). Feel free to reject the suggestions

Otherwise looks good to me!

src/sage/modular/quasimodform/element.py Outdated Show resolved Hide resolved
src/sage/modular/quasimodform/element.py Show resolved Hide resolved
src/sage/modular/quasimodform/element.py Show resolved Hide resolved
src/sage/modular/quasimodform/element.py Show resolved Hide resolved
Copy link
Contributor

@grhkm21 grhkm21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the final change.

src/sage/modular/quasimodform/element.py Outdated Show resolved Hide resolved
Copy link
Contributor

@grhkm21 grhkm21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you :)

Copy link

Documentation preview for this PR (built with commit 97286da; changes) is ready! 🎉

@DavidAyotte
Copy link
Member Author

Looks good! Thank you :)

Thank you for reviewing my PRs!

@vbraun vbraun merged commit 4ec03a8 into sagemath:develop Mar 25, 2024
17 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants